Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto_finish to FrameEncoder #95

Merged
merged 1 commit into from
Mar 4, 2023
Merged

feat: add auto_finish to FrameEncoder #95

merged 1 commit into from
Mar 4, 2023

Conversation

PSeitz
Copy link
Owner

@PSeitz PSeitz commented Mar 4, 2023

Fixes #94

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #95 (ce28ee6) into main (006db07) will decrease coverage by 0.75%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   90.14%   89.39%   -0.75%     
==========================================
  Files          11       11              
  Lines        2161     2179      +18     
==========================================
  Hits         1948     1948              
- Misses        213      231      +18     
Impacted Files Coverage Δ
src/frame/compress.rs 77.45% <0.00%> (-6.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit be2ea76 into main Mar 4, 2023
fn drop(&mut self) {
if let Some(mut encoder) = self.encoder.take() {
if let Err(err) = encoder.try_finish() {
panic!("Error when flushing frame on drop {:?} ", err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger abort if the thread is already panicking.

Copy link
Owner Author

@PSeitz PSeitz May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is already covered by a PR here: #100

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lz4 writer does not close properly
2 participants